Skip to content

implement new showDefaultGate semantics#14273

Merged
shtukas merged 4 commits intomainfrom
ph-20250723-1654-newsshowcase
Jul 25, 2025
Merged

implement new showDefaultGate semantics#14273
shtukas merged 4 commits intomainfrom
ph-20250723-1654-newsshowcase

Conversation

@shtukas
Copy link
Contributor

@shtukas shtukas commented Jul 23, 2025

At the moment the client send a mandatory attribute called mustShowDefaultGate in the payload to GetTreatments. This is a boolean attribute.

Here we make a change to this. First we rename the attribute from mustShowDefaultGate to showDefaultGate. Then the type is changed from a boolean to an optional string (essentially an enum value):

type ShowGateValues = 'true' | 'mandatory' | 'dismissible' | undefined;
  • undefined means that the attribute has no effect
  • true and dismissible will force the display of the GU default gate, its dismissible variant
  • mandatory will force the display of the GU default gate, its mandatory variant

@github-actions
Copy link

github-actions bot commented Jul 23, 2025

@github-actions
Copy link

github-actions bot commented Jul 23, 2025

@shtukas shtukas changed the title release utm_source=newsshowcase implement new showDefaultGate semantics Jul 25, 2025
@shtukas shtukas added the run_chromatic Runs chromatic when label is applied label Jul 25, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jul 25, 2025
@shtukas shtukas marked this pull request as ready for review July 25, 2025 08:31
@github-actions
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@shtukas shtukas merged commit 1ba97b4 into main Jul 25, 2025
29 checks passed
@shtukas shtukas deleted the ph-20250723-1654-newsshowcase branch July 25, 2025 10:38
@prout-bot
Copy link

Seen on PROD (merged by @shtukas 8 minutes and 56 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants